-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files for Mulliken tests in stdout-charges #15
Conversation
Please note btw that I chose to add the writing of the Mulliken charges to the output files that were already there for the Hirshfeld and Voronoi charges. This means that, in principle, the tests for those charges could be adapted to use these files instead of the old ones (which then could deleted). If this is undesirable I could also update these output files to only write the Mulliken charges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind, then I would suggest each run, gets a separate folder. That would enable one to subsequently add the DM
files to cross-reference the charges.
If you think this is a waste now, I will probably do it in some time.
I've moved the files for each different run into its own subfolder. Is it still sufficient to have a single |
It would be nice if you could add DM and 1 file which contains the overlap matrices, in that way we can double check the results from siesta, and from sisl ;) |
Maybe I could instead add the main netCDF output file ( |
The netcdf files would be great! Consider using the compression for minimal disk space, remember to update the input fdf files! |
I tried storing the |
…M from a previous run
Yes, i think so, lets do this. This actually opens up a new issue with Thanks! |
This PR adds files necessary for testing the parsing of the Mulliken charges in
stdoutSileSiesta
. See also zerothi/sisl#691